Issue with triggers in 1.4.0

Hey team,

We use the generic midi module to trigger calls from one of our projection systems to trigger actions in Companion. It’s worked well for a long time - thanks for your efforts!

We’ve just identified an issue with 1.4.0 - while the module in logs is showing that signals are received from the midi input, the trigger doesn’t ‘happen’. Reverting to 1.3.2 restores functionality.

Attached are the logs were receiving and an example of the trigger UI in Companion. Apologies, we’re live and I can’t go back to 1.4.0 at this time to see if logs are any different.

Happy to help try to resolve the issue if there’s more information needed to work through!

Thanks, Brodie

(Will upload other images once I have permissions :slight_smile: )

Your account trust has been increased, can you show me the trigger and the main log page (or export the support bundle) and I’ll look into this.

Thanks,

Here you go. I’m not at the PC at the moment. If you need more info I’ll drop in during hte week and generate more examples - just tell me what you need.

Thank you.

What I’ll need to see is all the parts of the trigger (you have some collapsed, and the action(s) aren’t shown)
Open the Module Log (click the 3 vertical dots beside the RCP module name in the Connections tab and select “View Log”) and on that log page, click “Stop” then “Clear” then “Start”.
Send it some MIDI commands that are supposed to trigger
Screenshot or export that log

then, Open the main Companion log and click “Export Support Bundle” and send that to me. You can DM it if you don’t want to post it here.

Next, try clicking “Test” on the trigger, does the action work when you do that?
Double-check that the trigger didn’t get disabled by accident.

Hey Andy,

PMed the files. Confirming that hte test on the triggers work.

As mentioned above, version 1.3.2 of the plugin works as expected, updating to 1.4.0 breaks the trigger - nothing appears to be sent to it as there’s no updated timestamp despite the trigger conditions being met.

Looking briefly at the companion log, there’s a consistent line that appears in there when a trigger should be fired that says a version of

“warn Instance/Connection/EntityManager/[string] Failed to parse options for entity [entityID] in control trigger:[triggerID]: {“varValue”:“Value must be at least 1 characters long”}”

This only appears in here when running version 1.4.0 of the plugin, at the times where the trigger ought have fired.

Let me know if you need anything else.

Sorry, attached is the MIDI log itself. Looks the same in 1.3.2 / 1.4.0 - channels/values captured as expected in here.

module-log-18_05_2026-7_34_22 pm.zip (722 Bytes)

I see the error in the log, thank you.

I don’t see you sending that specific MIDI message ch 1/note 2/vel 11 in the log.
Can you export that trigger or get me a screenshots showing all of the trigger information?

Also, what version of Companion are you running?

Ok, I think I see what happened.

You have some feedbacks or conditions that you have selected “Auto-Create Variable”, and for those, you had a value that was blank. The value shouldn’t have been needed, but because they always default to a value, they wouldn’t normally ever be blank, and in older versions, I guess it never mattered.
Should be fixed now.

Please try v1.4.1 from here and let me know.

Thanks Andy,

I can’t see any auto-create variable options in the triggers but there’s a bunch so I’ll go over in fine detail later. However, confirming 1.4.1 appears to resolve the issue we were having - thanks!

It’s in the “Conditions”, if you click “Use Variables”, you’ll probably see that the Velocity value becomes blank.
It’s nothing you did wrong but I’m not sure how it became blank, and because you couldn’t normally see it, there’s no way you would have been able to fix it.

Glad you reported it and I was able to fix it!